Fix static link issue in tooling #16174
Merged
+115
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
requested review from
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
kylesmartin
reviewed
Jan 31, 2025
| @@ -56,6 +58,40 @@ func DeployLinkToken(e deployment.Environment, chains []uint64) (deployment.Chan | |||
| return deployment.ChangesetOutput{AddressBook: newAddresses}, nil | |||
| } | |||
|
|
|||
| // DeployStaticLinkToken deploys a static link token contract to the chain identified by the ChainSelector. | |||
| func DeployStaticLinkToken(e deployment.Environment, chains []uint64) (deployment.ChangesetOutput, error) { | |||
There was a problem hiding this comment.
Should this be unexported? Function sig does not exactly match that of a changeset.
There was a problem hiding this comment.
Nvm, thrown off by primitive type as "config"
kylesmartin
previously approved these changes
Jan 31, 2025
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
tt-cll
previously approved these changes
Jan 31, 2025
|
tt-cll
approved these changes
Jan 31, 2025
kylesmartin
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports